This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/3] posix: Improve default posix_spawn implementation
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: libc-alpha at sourceware dot org
- Date: Mon, 3 Jul 2017 10:32:44 -0300
- Subject: Re: [PATCH 2/3] posix: Improve default posix_spawn implementation
- Authentication-results: sourceware.org; auth=none
- References: <1494876985-21990-1-git-send-email-adhemerval.zanella@linaro.org> <1494876985-21990-2-git-send-email-adhemerval.zanella@linaro.org> <mvm7ezulvqi.fsf@suse.de> <ed432eaf-2139-6fde-51ba-b85aa06a6ac3@linaro.org> <mvmy3sakegp.fsf@suse.de> <1a5a19ea-7a20-a71c-86ce-e0f302795401@linaro.org> <mvmpodij8ux.fsf@suse.de> <81e92d4c-d294-82c9-b8ce-9c6ad316f320@linaro.org> <mvmvan9isha.fsf@suse.de>
On 03/07/2017 10:02, Andreas Schwab wrote:
> On Jul 03 2017, Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote:
>
>> My understanding is POSIX is not strictly regarding spurious errno writes,
>> but on general information [1] it has the rationale:
>>
>> "In order to avoid this problem altogether for new functions, these
>> functions avoid using errno and, instead, return the error number directly
>> as the function return value; a return value of zero indicates that no
>> error was detected."
>
> It also notes (in section Signal Actions):
>
> "Note in particular that even the "safe'' functions may modify the global
> variable errno"
So it is more an implementation detail and/or QoI to whether modify errno
on such functions and see no impeding reason of doing it on posix_spawn.
The only rationale I am not sure is if its worth to remove clone wrapper
error path setting errno.