This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] float128: Add signbit alternative for old compilers
- From: Joseph Myers <joseph at codesourcery dot com>
- To: "Gabriel F. T. Gomes" <gftg at linux dot vnet dot ibm dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Fri, 30 Jun 2017 20:40:25 +0000
- Subject: Re: [PATCH] float128: Add signbit alternative for old compilers
- Authentication-results: sourceware.org; auth=none
- References: <1498854080-14778-1-git-send-email-gftg@linux.vnet.ibm.com>
On Fri, 30 Jun 2017, Gabriel F. T. Gomes wrote:
> +int
> +__signbitf128 (_Float128 x)
> +{
> + int64_t e;
> +
> + GET_FLOAT128_MSW64 (e, x);
> + return e < 0;
I think you should use __builtin_signbit for GCC >= 6, with a comment that
once GCC >= 6 is required for building glibc, this file can go back to
wrapping the float128 version. OK with that change.
--
Joseph S. Myers
joseph@codesourcery.com