This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH RESEND] zic, various tests: use LFS I/O functions explicitly where needed
On 27 Jun 2017, Paul Eggert uttered the following:
> Nick Alcock wrote:
>
>> we've seen zic fail with bizarre error messages in this situation
>> already.
>
> I think those failures were fixed by the EOVERFLOW check that is in
> zic already.
Argh, yes, of course, what were we just *talking* about! :) of course it
is and I am talking rubbish. I guess I should change the patch subject
at least, since it's all tests now...
> That being said, the patch shouldn't hurt correctness and
> should help performance a bit in some cases, so I just now installed a
> more-portable patch upstream. Please see:
>
> http://mm.icann.org/pipermail/tz/2017-June/025164.html
Looks fine.
> So, an alternative to your patch would be to install this upstream
> patch (it's OK to have both patches, of course).
I'll leave that decision up to you. I'm happy to drop this bit now and
make this a test-only patch.
--
NULL && (void)