This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Make libm-test-support code clear exceptions after each test [committed]
- From: Joseph Myers <joseph at codesourcery dot com>
- To: <libc-alpha at sourceware dot org>
- Date: Fri, 23 Jun 2017 20:11:22 +0000
- Subject: Make libm-test-support code clear exceptions after each test [committed]
- Authentication-results: sourceware.org; auth=none
The libm-test-support code clears exceptions at the end of
test_exceptions. However, it's possible that exceptions get raised as
part of the subsequent checks on the results of the function being
tested, and such exceptions then carry through to the next test run
and can cause that to fail spuriously. In particular, it's possible
for the ulps calculation to raise exceptions in some cases. This
patch puts exception clearing at the end of each of the check_*
functions, alongside errno clearing, to avoid one test affecting the
next in that way.
Tested for x86_64 (in conjunction with float128 patches). Committed.
2017-06-23 Joseph Myers <joseph@codesourcery.com>
* libm-test-support.c (check_float_internal): Clear exceptions at
end of function.
(check_int): Likewise.
(check_long): Likewise.
(check_bool): Likewise.
(check_longlong): Likewise.
(check_intmax_t): Likewise.
(check_uintmax_t): Likewise.
diff --git a/math/libm-test-support.c b/math/libm-test-support.c
index 7612d39..078d307 100644
--- a/math/libm-test-support.c
+++ b/math/libm-test-support.c
@@ -718,6 +718,7 @@ check_float_internal (const char *test_name, FLOAT computed, FLOAT expected,
out:
fpstack_test (test_name);
+ feclearexcept (FE_ALL_EXCEPT);
errno = 0;
}
@@ -795,6 +796,7 @@ check_int (const char *test_name, int computed, int expected,
update_stats (ok);
out:
fpstack_test (test_name);
+ feclearexcept (FE_ALL_EXCEPT);
errno = 0;
}
@@ -828,6 +830,7 @@ check_long (const char *test_name, long int computed, long int expected,
update_stats (ok);
out:
fpstack_test (test_name);
+ feclearexcept (FE_ALL_EXCEPT);
errno = 0;
}
@@ -861,6 +864,7 @@ check_bool (const char *test_name, int computed, int expected,
update_stats (ok);
out:
fpstack_test (test_name);
+ feclearexcept (FE_ALL_EXCEPT);
errno = 0;
}
@@ -895,6 +899,7 @@ check_longlong (const char *test_name, long long int computed,
update_stats (ok);
out:
fpstack_test (test_name);
+ feclearexcept (FE_ALL_EXCEPT);
errno = 0;
}
@@ -928,6 +933,7 @@ check_intmax_t (const char *test_name, intmax_t computed,
update_stats (ok);
out:
fpstack_test (test_name);
+ feclearexcept (FE_ALL_EXCEPT);
errno = 0;
}
@@ -961,6 +967,7 @@ check_uintmax_t (const char *test_name, uintmax_t computed,
update_stats (ok);
out:
fpstack_test (test_name);
+ feclearexcept (FE_ALL_EXCEPT);
errno = 0;
}
--
Joseph S. Myers
joseph@codesourcery.com