This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] x86-64: memcmp-avx2-movbe.S needs saturating subtraction [BZ #21662]
- From: Florian Weimer <fweimer at redhat dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 23 Jun 2017 17:12:32 +0200
- Subject: Re: [PATCH] x86-64: memcmp-avx2-movbe.S needs saturating subtraction [BZ #21662]
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=fweimer at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 195EFBAEC1
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 195EFBAEC1
- References: <20170623132026.82F2D4017D45E@oldenburg.str.redhat.com> <6fec374c-177f-b8e8-d7a3-ab10d7dab136@redhat.com> <CAMe9rOphhifhpjeBUiHzDxwBZvTY7S_Z8EWbUHWgY-i-gbn+vg@mail.gmail.com>
On 06/23/2017 05:08 PM, H.J. Lu wrote:
> On Fri, Jun 23, 2017 at 6:51 AM, Florian Weimer <fweimer@redhat.com> wrote:
>> I think this revised patch is an improvement because it avoids adding a
>> branch.
>>
>> Thanks,
>> Florian
>
> The memcmp-avx2-movbe.S part is OK.
Thanks, I will commit it shortly.
> For
>
> (check_result, do_random_tests): Write error messages to standard
> output.
>
> any particular reason to replace error with printf?
The error function writes to standard error, so the test harness does
not capture it output in the .out file.
Thanks,
Florian