This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCHv2] powerpc: Add optimized version of [l]lroundf
- From: "Tulio Magno Quites Machado Filho" <tuliom at linux dot vnet dot ibm dot com>
- To: Rajalakshmi Srinivasaraghavan <raji at linux dot vnet dot ibm dot com>, libc-alpha at sourceware dot org
- Cc:
- Date: Thu, 22 Jun 2017 13:08:37 -0300
- Subject: Re: [PATCHv2] powerpc: Add optimized version of [l]lroundf
- Authentication-results: sourceware.org; auth=none
- References: <1498024363-5326-1-git-send-email-raji@linux.vnet.ibm.com>
Rajalakshmi Srinivasaraghavan <raji@linux.vnet.ibm.com> writes:
> This patch makes use of optimized double version of llround for single
> precision as both the versions return [long] long type.
>
> 2017-06-21 Rajalakshmi Srinivasaraghavan <raji@linux.vnet.ibm.com>
>
> * sysdeps/powerpc/powerpc64/fpu/multiarch/Makefile
> (libm-sysdep_routines): Add s_llroundf-ppc64.
> * sysdeps/powerpc/powerpc64/power5+fpu/s_llround.S
> (__llroundf): Define as strong alias of __llround.
> (llroundf): Define as weak alias of __llround.
> (__lroundf): Define as strong alias of __llround.
> (lroundf): Define as weak alias of __llround.
> * sysdeps/powerpc/powerpc64/power6x/fpu/s_llround.S: Likewise.
> * sysdeps/powerpc/powerpc64/power8/fpu/s_llround.S: Likewise.
> * sysdeps/powerpc/powerpc64/fpu/multiarch/s_llroundf-ppc64.S: New file.
> * sysdeps/powerpc/powerpc64/fpu/multiarch/s_llroundf.c: Likewise.
OK
> * sysdeps/powerpc/powerpc64/power5+/fpu/s_llround.S: Likewise.
> * sysdeps/powerpc/powerpc64/power6x/fpu/s_llround.S: Likewise.
> * sysdeps/powerpc/powerpc64/power8/fpu/s_llround.S: Likewise.
I think the last 3 files should be s_llroundf.S.
Looks good to me with those changes.
--
Tulio Magno