This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCHv2] powerpc: Add optimized version of [l]lroundf


Rajalakshmi Srinivasaraghavan <raji@linux.vnet.ibm.com> writes:

> This patch makes use of optimized double version of llround for single
> precision as both the versions return [long] long type.
>
> 2017-06-21  Rajalakshmi Srinivasaraghavan  <raji@linux.vnet.ibm.com>
>
> 	* sysdeps/powerpc/powerpc64/fpu/multiarch/Makefile
> 	(libm-sysdep_routines): Add s_llroundf-ppc64.
> 	* sysdeps/powerpc/powerpc64/power5+fpu/s_llround.S
> 	(__llroundf): Define as strong alias of __llround.
> 	(llroundf):  Define as weak alias of __llround.
> 	(__lroundf): Define as strong alias of __llround.
> 	(lroundf):  Define as weak alias of __llround.
> 	* sysdeps/powerpc/powerpc64/power6x/fpu/s_llround.S:  Likewise.
> 	* sysdeps/powerpc/powerpc64/power8/fpu/s_llround.S: Likewise.
> 	* sysdeps/powerpc/powerpc64/fpu/multiarch/s_llroundf-ppc64.S: New file.
> 	* sysdeps/powerpc/powerpc64/fpu/multiarch/s_llroundf.c: Likewise.

OK

> 	* sysdeps/powerpc/powerpc64/power5+/fpu/s_llround.S: Likewise.
> 	* sysdeps/powerpc/powerpc64/power6x/fpu/s_llround.S: Likewise.
> 	* sysdeps/powerpc/powerpc64/power8/fpu/s_llround.S: Likewise.

I think the last 3 files should be s_llroundf.S.

Looks good to me with those changes.

-- 
Tulio Magno


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]