This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] tunables: Add IFUNC selection and cache sizes


On Wednesday 21 June 2017 06:56 PM, H.J. Lu wrote:
> I am testing this patch.  OK for master if there are no regressions?
> 

Looks OK to me with one comment change which I missed the last time:

>       Since all CPU/ARCH features are hardware optimizations without
>       security implication, except for Prefer_MAP_32BIT_EXEC, which can
> -     only be disabled, we check GLIBC_IFUNC for programs, including
> +     only be disabled, we check glibc.tune.hwcaps for programs, including
>       set*id ones.

This block is no longer valid since the tunables are not read for setxid
binaries.  If you want to make a case for hwcaps to be read in setxid
binaries, then it should be made along with hwcap_mask since they're
essentially the same feature for different machines.

Siddhesh


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]