This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2][AArch64] Add more cfi annotations to tlsdesc entry points
- From: Szabolcs Nagy <szabolcs dot nagy at arm dot com>
- To: Richard Henderson <rth at twiddle dot net>, GNU C Library <libc-alpha at sourceware dot org>
- Cc: nd at arm dot com, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>, Florian Weimer <fweimer at redhat dot com>
- Date: Wed, 21 Jun 2017 15:05:35 +0100
- Subject: Re: [PATCH v2][AArch64] Add more cfi annotations to tlsdesc entry points
- Authentication-results: sourceware.org; auth=none
- Authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=arm.com;
- Nodisclaimer: True
- References: <584AB057.5050605@arm.com> <39560805-b142-5681-4f39-096bf7045e2a@twiddle.net> <584FEAE9.10207@arm.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On 13/12/16 12:34, Szabolcs Nagy wrote:
> Backtrace through _dl_tlsdesc_resolve_rela was broken because the offset
> of x30 from cfa was not in the debug info.
>
> Add enough annotation so backtracing from the dynamic linker through
> tlsdesc entry points works and the debugger shows registers correctly.
>
> v2:
> - group cfi_rel_offset annotations for smaller debug info.
>
> 2016-12-13 Szabolcs Nagy <szabolcs.nagy@arm.com>
>
> * sysdeps/aarch64/dl-tlsdesc.S (_dl_tlsdesc_dynamic): Add cfi
> annotation.
> (_dl_tlsdesc_resolve_rela, _dl_tlsdesc_resolve_hold): Likewise.
>
committed.