This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 01/12] RISC-V: Build Infastructure
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Palmer Dabbelt <palmer at dabbelt dot com>
- Cc: <libc-alpha at sourceware dot org>, Andrew Waterman <andrew at sifive dot com>, <patches at groups dot riscv dot org>, Darius Rad <darius at bluespec dot com>
- Date: Tue, 20 Jun 2017 11:52:51 +0000
- Subject: Re: [PATCH 01/12] RISC-V: Build Infastructure
- Authentication-results: sourceware.org; auth=none
- References: <mhng-d2b623c3-41a5-469e-a00a-b2da74889a83@palmer-si-x1c4>
On Mon, 19 Jun 2017, Palmer Dabbelt wrote:
> >> diff --git a/sysdeps/riscv/Versions b/sysdeps/riscv/Versions
> >> new file mode 100644
> >> index 0000000000..5a0c2d23f8
> >> --- /dev/null
> >> +++ b/sysdeps/riscv/Versions
> >> @@ -0,0 +1,5 @@
> >> +libc {
> >> + GLIBC_2.14 {
> >> + __memcpy_g;
> >> + }
> >> +}
> >
> > No, the minimum version should be 2.26, and you shouldn't need any such
> > special string variants (given that we've killed bits/string2.h, are about
> > to kill bits/string.h, and such exports as there are from old string
> > function inlines are or should soon be compat symbols).
>
> OK, makes sense.
>
> https://github.com/riscv/riscv-glibc/commit/bbab2031f32970763a0327925fabde969fcd9a77
I'd expect this file to go away completely, instead of listing an empty
GLIBC_2.26 version.
> I think we missed the -I when regenerating this, it's been fixed
>
> https://github.com/riscv/riscv-glibc/commit/bcb054441d6fe79c231a8420c67da907fa1ce10f
It looks like your regeneration adds a blank line at the end of configure.
Files ending with blank lines (or whitespace at end of lines, or spaces
before tabs) can't be pushed to the glibc repository; you'll need a
comment at the end of configure.ac (as in some other versions) to avoid
such a blank line at the end of configure.
--
Joseph S. Myers
joseph@codesourcery.com