This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] DCIGETTEXT: Do not make copy of localename



On 19/06/2017 13:16, Florian Weimer wrote:
> 2017-06-19  Florian Weimer  <fweimer@redhat.com>
> 
> 	* intl/dcigettext.c (DCIGETTEXT): Do not make copy of localename.
> 	It cannot change while __libc_setlocale_lock is acquired.

LGTM.

> 
> diff --git a/intl/dcigettext.c b/intl/dcigettext.c
> index 3843b7c..d97746c 100644
> --- a/intl/dcigettext.c
> +++ b/intl/dcigettext.c
> @@ -551,7 +551,7 @@ DCIGETTEXT (const char *domainname, const char *msgid1, const char *msgid2,
>  #ifdef HAVE_PER_THREAD_LOCALE
>  # ifndef IN_LIBGLOCALE
>  #  ifdef _LIBC
> -  localename = strdupa (__current_locale_name (category));
> +  localename = __current_locale_name (category);
>  #  else
>    categoryname = category_to_name (category);
>  #   define CATEGORYNAME_INITIALIZED
> 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]