This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: RFC: pwritev2 regression test for invalid flags
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: Christoph Hellwig <hch at infradead dot org>, Jon Derrick <jonathan dot derrick at intel dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>, Stephen Bates <sbates at raithlin dot com>, "linux-block at vger dot kernel dot org" <linux-block at vger dot kernel dot org>, Christoph Hellwig <hch at lst dot de>, Jens Axboe <axboe at fb dot com>, viro at zeniv dot linux dot org dot uk
- Date: Fri, 16 Jun 2017 10:01:52 -0300
- Subject: Re: RFC: pwritev2 regression test for invalid flags
- Authentication-results: sourceware.org; auth=none
- References: <a5987ece-5351-346b-21fd-5a3e0092229e@linaro.org> <43631a74-8934-6940-3eaa-e562e49c5cb2@intel.com> <20170616060459.GA5472@infradead.org>
On 16/06/2017 03:04, Christoph Hellwig wrote:
> On Thu, Jun 01, 2017 at 11:52:25AM -0600, Jon Derrick wrote:
>> Can you apply the patch below to your kernel?
>
> I've already sent this patch to Al twice (including a stable tag),
> but it didn't seem to make it anywhere.
Right, thanks for the reply. So it is a kernel issue and I think it
should not prevent us to use it a regression test.
>
>> diff --git a/fs/read_write.c b/fs/read_write.c
>> index c4f88af..f77eb22 100644
>> --- a/fs/read_write.c
>> +++ b/fs/read_write.c
>> @@ -1210,7 +1210,7 @@ static size_t compat_writev(struct file *file,
>> if (!(file->f_mode & FMODE_CAN_WRITE))
>> goto out;
>>
>> - ret = compat_do_readv_writev(WRITE, file, vec, vlen, pos, 0);
>> + ret = compat_do_readv_writev(WRITE, file, vec, vlen, pos, flags);
>>
>> out:
>> if (ret > 0)
> ---end quoted text---
>