This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Allocation buffers for NSS result construction
- From: Florian Weimer <fweimer at redhat dot com>
- To: GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 16 Jun 2017 14:20:30 +0200
- Subject: Re: [PATCH] Allocation buffers for NSS result construction
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=fweimer at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 2004680464
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 2004680464
- References: <2526706e-18e7-1c30-84b3-812663c43b98@redhat.com>
On 04/22/2017 09:47 PM, Florian Weimer wrote:
> 2017-04-22 Florian Weimer <fweimer@redhat.com>
>
> * malloc/Makefile (tests): Add tst-alloc_buffer.
> (routines): Add alloc_buffer_alloc_array, alloc_buffer_allocate,
> alloc_buffer_copy_bytes.
> * malloc/Versions (__libc_alloc_buffer_alloc_array)
> (__libc_alloc_buffer_allocate, __libc_alloc_buffer_copy_bytes):
> Export as GLIBC_PRIVATE.
> * malloc/alloc_buffer_alloc_array.c: New file.
> * malloc/alloc_buffer_allocate.c: Likewise.
> * malloc/alloc_buffer_copy_bytes.c: Likewise.
> * malloc/alloc_buffer_copy_string.c: Likewise.
> * malloc/tst-alloc_buffer.c: Likewise.
> * resolv/Versions (__ns_name_ntop_buffer)
> (__ns_name_unpack_buffer): Export as GLIBC_PRIVATE.
> * resolv/ns_name.c (__ns_name_ntop_buffer): New function.
> (ns_name_ntop): Implement using __ns_name_ntop_buffer.
> (__ns_name_unpack_buffer): New function.
> (ns_name_unpack): Implement using __ns_name_unpack_buffer.
> * resolv/nss_dns/dns-network.c (_nss_dns_getnetbyname_r)
> (_nss_dns_getnetbyaddr_r): Adjust call to getanswer_r.
> (getanswer_r): Store result in an allocation buffer. Use
> __ns_name_ntop_buffer instead of ns_name_ntop. Remove superfluous
> call to res_dnok because ns_name_ntop output is always printable
> ASCII.
Any further comments? I'd like to commit this.
Thanks,
Florian