This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 6/6] Deprecate xlocale.h and add bits/types/locale_t.h.
- From: Florian Weimer <fweimer at redhat dot com>
- To: Zack Weinberg <zackw at panix dot com>, libc-alpha at sourceware dot org
- Cc: joseph at codesourcery dot com
- Date: Wed, 14 Jun 2017 13:11:51 +0200
- Subject: Re: [PATCH 6/6] Deprecate xlocale.h and add bits/types/locale_t.h.
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=fweimer at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 79A42C056791
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 79A42C056791
- References: <20170610171738.22362-1-zackw@panix.com> <20170610171738.22362-7-zackw@panix.com>
On 06/10/2017 07:17 PM, Zack Weinberg wrote:
> xlocale.h is already a single-type micro-header, defining locale_t, so
> it would be nice to bring it into the overall bits/types/ scheme.
> Unfortunately, it's in the top level of the system-header namespace
> and, despite the comment saying "This file is not standardized, don't
> rely on it, it can go away without warning", there are a lot of
> external uses, so we need to deprecate it first, which is what this
> patch does.
I would suggest to remove it outright. I saw quite a few references to
<xlocale.h> covered under autoconf tests. Removal means that the tests
fail, and the #include <xlocale.h> is #ifdef'ed out in the actual
sources. A deprecation warning will cause the autoconf test to fail,
but then the #include may still fail due to the deprecation warning and
-Werror.
Thanks,
Florian