This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 3/6] Remove __need_IOV_MAX and __need_FOPEN_MAX.


On Sat, 10 Jun 2017, Zack Weinberg wrote:

> diff --git a/bits/uio-ext.h b/bits/uio-ext.h
> new file mode 100644
> index 0000000000..8f36e960bf
> --- /dev/null
> +++ b/bits/uio-ext.h
> @@ -0,0 +1,27 @@
> +/* Copyright (C) 1991-2017 Free Software Foundation, Inc.
> +   This file is part of the GNU C Library.

Should have a descriptive comment before the copyright notice.

> diff --git a/sysdeps/unix/sysv/linux/bits/uio_lim.h b/sysdeps/unix/sysv/linux/bits/uio_lim.h
> new file mode 100644
> index 0000000000..7c69b93d31
> --- /dev/null
> +++ b/sysdeps/unix/sysv/linux/bits/uio_lim.h
> @@ -0,0 +1,31 @@
> +/* Copyright (C) 1996-2017 Free Software Foundation, Inc.
> +   This file is part of the GNU C Library.

Likewise.

OK with that fixed and with the ChangeLog entry updated so it only 
mentions those struct_iovec.h-related changes that are actually new, not 
things such as adding that header in the first place that are already in 
the tree.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]