This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Replace __bzero with memset
Zack Weinberg wrote:
On Mon, Jun 12, 2017 at 1:51 PM, Joseph Myers <joseph@codesourcery.com> wrote:
> The string2.h removal breaks build for 32-bit x86.
>
> In file included from ../string/string-inlines.c:32:0,
> from ../sysdeps/i386/string-inlines.c:21:
> ../sysdeps/x86/bits/string.h:678:0: error: "__stpcpy" redefined [-Werror]
> # define __stpcpy(dest, src) \
>
> In file included from ../string/string-inlines.c:27:0,
> from ../sysdeps/i386/string-inlines.c:21:
> ../include/string.h:167:0: note: this is the location of the previous definition
> # define __stpcpy(dest, src) __builtin_stpcpy (dest, src)
>
> cc1: all warnings being treated as errors
Oops, it seems the include order is different in string-inlines.c.
> This should get fixed, but FYI, in about two hours I'm going to
> propose a patch to zap bits/string.h. :)
I think adding a #undef next to the existing #undefs in string-inlines.c should do it.
Wilco