This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Replace __bzero with memset
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Zack Weinberg <zackw at panix dot com>
- Cc: Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, nd <nd at arm dot com>
- Date: Mon, 12 Jun 2017 17:51:38 +0000
- Subject: Re: [PATCH] Replace __bzero with memset
- Authentication-results: sourceware.org; auth=none
- References: <AM5PR0802MB2610A62A60E00B406466E76983CD0@AM5PR0802MB2610.eurprd08.prod.outlook.com> <CAKCAbMjfOrJN0sauR0eyuq3amt3nRz3HbstX7G=uBpfkyj0gmA@mail.gmail.com>
The string2.h removal breaks build for 32-bit x86.
In file included from ../string/string-inlines.c:32:0,
from ../sysdeps/i386/string-inlines.c:21:
../sysdeps/x86/bits/string.h:678:0: error: "__stpcpy" redefined [-Werror]
# define __stpcpy(dest, src) \
In file included from ../string/string-inlines.c:27:0,
from ../sysdeps/i386/string-inlines.c:21:
../include/string.h:167:0: note: this is the location of the previous definition
# define __stpcpy(dest, src) __builtin_stpcpy (dest, src)
cc1: all warnings being treated as errors
Also, Wilco, please use git-style commit messages which start with a
single line with a short summary of the change, then a blank line, then
any further details (as in the mailing list message proposing a patch).
"2017-06-12 Wilco Dijkstra <wdijkstr@arm.com>" is not a good patch
summary.
--
Joseph S. Myers
joseph@codesourcery.com