This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/3] Add hidden_proto for getauxval

From: Richard Henderson <rth at twiddle dot net>
To: Florian Weimer <fweimer at redhat dot com>, libc-alpha at sourceware dot org
Date: Fri, 9 Jun 2017 15:11:10 -0700
Subject: Re: [PATCH 2/3] Add hidden_proto for getauxval
Authentication-results: sourceware.org; auth=none
References: <20170608225728.26779-1-rth@twiddle.net> <20170608225728.26779-3-rth@twiddle.net> <e1ab1443-1494-269c-f2fd-4485f70ae0d9@redhat.com> <6f525b6c-24c9-798f-353b-a8bda5f194ca@twiddle.net> <7ee77dce-dd50-6d1c-1ad8-452b6990b8f3@redhat.com>

On 06/09/2017 10:49 AM, Florian Weimer wrote:

On 06/09/2017 07:45 PM, Richard Henderson wrote:

On 06/08/2017 11:58 PM, Florian Weimer wrote:

On 06/09/2017 12:57 AM, Richard Henderson wrote:

+libc_hidden_weak (getauxval)


This should be libc_hidden_proto (__getauxval).  I don't think you can
call getauxval from libc.so because it leads to a namespace violation.


 From libc.so you certainly can, because we'll actually call __GI_getauxval.


Yes, but not from libc.a, which is better to have the hidden alias for
the __ variant.


Quite right.


r~

References:
- [PATCH 0/3] Add some missing cache infomation
  - From: Richard Henderson
- [PATCH 2/3] Add hidden_proto for getauxval
  - From: Richard Henderson
- Re: [PATCH 2/3] Add hidden_proto for getauxval
  - From: Florian Weimer
- Re: [PATCH 2/3] Add hidden_proto for getauxval
  - From: Richard Henderson
- Re: [PATCH 2/3] Add hidden_proto for getauxval
  - From: Florian Weimer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]