This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] getaddrinfo: Always allocate canonical name on the heap

From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
To: Florian Weimer <fweimer at redhat dot com>
Cc: libc-alpha at sourceware dot org
Date: Fri, 2 Jun 2017 14:50:46 -0300
Subject: Re: [PATCH] getaddrinfo: Always allocate canonical name on the heap
Authentication-results: sourceware.org; auth=none
References: <20170511100718.1F66A401E714A@oldenburg.str.redhat.com> <52802461-8188-52e7-eeba-9cdce0be340d@linaro.org> <2738bd73-a636-1e6e-7eb0-225c99d91b5d@redhat.com> <a065149c-7c28-4a4a-530b-4a0910ae0884@linaro.org> <7ba94b4d-c575-e122-17d0-8f00edfa21a6@redhat.com>


On 02/06/2017 11:37, Florian Weimer wrote:
> On 06/02/2017 04:10 PM, Adhemerval Zanella wrote:
>> I noticed on x86_64 (gcc 5.4), powerpc64le (gcc 5.4), aarch64 (gcc 4.9.2),
>> and sparc64 (gcc 6.3.1).  My guess is newer GCC versions are inline it.
> 
> Fair enough.  What about the attached patch?  I spotted one missing heap
> allocation (which is not visible as a bug because the code doesn't try
> to pass the pointer to free), and included that as well.
> 
> Thanks,
> Florian
> 

LGTM, thanks.

References:
- Re: [PATCH] getaddrinfo: Always allocate canonical name on the heap
  - From: Adhemerval Zanella
- Re: [PATCH] getaddrinfo: Always allocate canonical name on the heap
  - From: Florian Weimer
- Re: [PATCH] getaddrinfo: Always allocate canonical name on the heap
  - From: Adhemerval Zanella
- Re: [PATCH] getaddrinfo: Always allocate canonical name on the heap
  - From: Florian Weimer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]