This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] getaddrinfo: Always allocate canonical name on the heap
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Fri, 2 Jun 2017 11:10:47 -0300
- Subject: Re: [PATCH] getaddrinfo: Always allocate canonical name on the heap
- Authentication-results: sourceware.org; auth=none
- References: <20170511100718.1F66A401E714A@oldenburg.str.redhat.com> <52802461-8188-52e7-eeba-9cdce0be340d@linaro.org> <2738bd73-a636-1e6e-7eb0-225c99d91b5d@redhat.com>
On 02/06/2017 11:05, Florian Weimer wrote:
> On 06/02/2017 03:56 PM, Adhemerval Zanella wrote:
>>> +static char *
>>> +getcanonname (service_user *nip, struct gaih_addrtuple *at, const char *name)
>>> +{
>
>>> + return strdup (name);
>>> +}
>
>> I think you need to use __strdup here, I am seeing check-local-plt failures on
>> master.
>
> On which architecture? I don't get see it on x86-64.
>
> I can push a fix blindly (based on the headers, it indeed needs to be
> __strdup).
>
> Thanks,
> Florian
>
I noticed on x86_64 (gcc 5.4), powerpc64le (gcc 5.4), aarch64 (gcc 4.9.2),
and sparc64 (gcc 6.3.1). My guess is newer GCC versions are inline it.