This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/6] float128: Add conversion from float128 to mpn
- From: "Gabriel F. T. Gomes" <gftg at linux dot vnet dot ibm dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Thu, 1 Jun 2017 20:52:24 -0300
- Subject: Re: [PATCH 2/6] float128: Add conversion from float128 to mpn
- Authentication-results: sourceware.org; auth=none
- References: <1495803396-14558-1-git-send-email-gftg@linux.vnet.ibm.com> <1495803396-14558-3-git-send-email-gftg@linux.vnet.ibm.com> <alpine.DEB.2.20.1705261531140.31473@digraph.polyomino.org.uk> <20170529233114.249cee23@keller.br.ibm.com> <alpine.DEB.2.20.1706011315390.6083@digraph.polyomino.org.uk>
On Thu, 1 Jun 2017 13:23:25 +0000
Joseph Myers <joseph@codesourcery.com> wrote:
> On Mon, 29 May 2017, Gabriel F. T. Gomes wrote:
>
> > I attached a new patch which replaces the definition of MAX and MIN in
> > stdlib/gmp-impl.h with an inclusion of sys/param.h.
> >
> > Is the attached patch OK for master?
>
> That patch is OK.
Thanks. I've committed it.
> This sounds like an include ordering problem. float128_private.h
> redefines lots of names from math_private.h and math.h. But that doesn't
> cause problems because it includes those headers first. So how about
> making float128_private.h include gmp.h before redefining
> __mpn_extract_long_double?
Thanks again. I rewrote this and I'll send again with the other patches
in the series.