This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/4] tunables: Use glibc.tune.hwcap_mask tunable instead of _dl_hwcap_mask



On 30/05/2017 21:30, Siddhesh Poyarekar wrote:
> On Wednesday 31 May 2017 02:51 AM, Adhemerval Zanella wrote:
>> On 25/05/2017 17:25, Siddhesh Poyarekar wrote:
>>> +
>>> +#include <elf/dl-tunables.h>
>>> +
>>> +#ifdef SHARED
>>> +# if HAVE_TUNABLES
>>> +#  define GET_HWCAP_MASK() TUNABLE_GET (glibc, tune, hwcap_mask, uint64_t)
>>> +# else
>>
>> I think this patchset is missing the previous TUNABLE_GET one [1] (build
>> fail with --enable-tunables).
> 
> I did not repost 1/5, 2/5 and 4/5 since they were already acked.  I can
> post the whole set again if you want.
> 
> 4/5 in fact is independent and can be pushed.

I would prefer to maintain consistence and avoid trying to figure out in
which order should I apply the patches to actually test it.  So If I get it
right, I need to apply v2 patch 1 and patch2, v3 patch 1 to 4, and finally
v2 patch 5? 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]