This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Add memchr tests for n == 0
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: libc-alpha at sourceware dot org
- Date: Thu, 25 May 2017 15:17:46 -0300
- Subject: Re: [PATCH] Add memchr tests for n == 0
- Authentication-results: sourceware.org; auth=none
- References: <20170524154656.GA14807@lucon.org>
On 24/05/2017 12:46, H.J. Lu wrote:
> Any comments?
>
> H.J.
> * string/test-memchr.c (test_main): Add tests for n == 0.
> ---
> string/test-memchr.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/string/test-memchr.c b/string/test-memchr.c
> index 669e092..73a93f0 100644
> --- a/string/test-memchr.c
> +++ b/string/test-memchr.c
> @@ -179,6 +179,10 @@ test_main (void)
>
> for (i = 1; i < 8; ++i)
> {
> + /* Test n == 0. */
> + do_test (i, i, 0, 0, 23);
> + do_test (i, i, 0, 0, 0);
> +
> do_test (0, 16 << i, 2048, 2048, 23);
> do_test (i, 64, 256, 256, 23);
> do_test (0, 16 << i, 2048, 2048, 0);
>
LGTM, thanks.