This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Use an alias to `ptsname_r' in login/tst-ptsname.c
- From: Florian Weimer <fweimer at redhat dot com>
- To: Arjun Shankar <arjun dot is at lostca dot se>
- Cc: Joseph Myers <joseph at codesourcery dot com>, libc-alpha at sourceware dot org
- Date: Thu, 25 May 2017 18:22:42 +0200
- Subject: Re: [PATCH] Use an alias to `ptsname_r' in login/tst-ptsname.c
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=fweimer at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com DAE31C056792
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com DAE31C056792
- References: <20170524155000.GA45792@aloka.lostca.se> <alpine.DEB.2.20.1705241617190.29027@digraph.polyomino.org.uk> <95b2e42d-80e4-4087-0c31-e850fcb913ff@redhat.com> <20170525160537.GA61035@aloka.lostca.se>
On 05/25/2017 06:05 PM, Arjun Shankar wrote:
> Given this, maybe in the case of `ptsname_r' it is enough to just drop
> the specific test that tests with NULL, and leave the man-page
> unchanged?
That's fine as well. I don't know if others want to preserve the EINVAL
handling.
> While we are at it, we could also drop the test for NULL in
> `ptsname_r'. How does that sound for a PATCH v2?
That would require updating the manpage, wouldn't it?
Thanks,
Florian