This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Tests for res_init
- From: Florian Weimer <fweimer at redhat dot com>
- To: Siddhesh Poyarekar <siddhesh at gotplt dot org>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Thu, 18 May 2017 20:37:07 +0200
- Subject: Re: [PATCH] Tests for res_init
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=fweimer at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 2B8CDC049D5C
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 2B8CDC049D5C
- References: <2b4fc76e-e756-e4e4-11ca-829a03cf84bb@redhat.com> <43792192-037e-6c6f-3988-11755e30c2c7@gotplt.org>
On 05/18/2017 08:33 PM, Siddhesh Poyarekar wrote:
> On Tuesday 09 May 2017 05:34 PM, Florian Weimer wrote:
>> The attached patch adds various tests for res_init and other
>> initialization functions. Bugs 21474 (already fixed) and 21475 were
>> discovered while writing these tests. I did not bother to fix bug 21475
>> (search path truncation) because it will be gone with a larger
>> resolv.conf parser rewrite anyway.
>
> Could you get the test for 21475 out of this patch? You could add that
> in with the parser rewrite later. That way this patch won't result in
> failures in the testsuite.
I can make this clearer in the comment. The test currently contains the
wrong expected output, as a remainder to update the bug when this is fixed.
Thanks,
Florian