This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] sunrpc: xdr_bytes/xdr_string need to free buffer on error [BZ #21461]

From: Andreas Schwab <schwab at suse dot de>
To: Florian Weimer <fweimer at redhat dot com>
Cc: libc-alpha at sourceware dot org
Date: Mon, 15 May 2017 14:48:18 +0200
Subject: Re: [PATCH] sunrpc: xdr_bytes/xdr_string need to free buffer on error [BZ #21461]
Authentication-results: sourceware.org; auth=none
References: <20170505131828.16EBC402C427D@oldenburg.str.redhat.com> <91e971f6-a9d6-f6d3-5202-5b6392e23c94@redhat.com> <mvmfugfu4i4.fsf@suse.de> <48cc85c6-52ac-c2ce-fd9a-2612eb7bcee7@redhat.com>

On Mai 08 2017, Florian Weimer <fweimer@redhat.com> wrote:

> But things get a bit weird for xdr_string here.  It calls strlen on the
> allocated buffer, which is not initialized after a deserialization
> failure.

It is always zero-terminated, at least.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

References:
- [PATCH] sunrpc: xdr_bytes/xdr_string need to free buffer on error [BZ #21461]
  - From: Florian Weimer
- Re: [PATCH] sunrpc: xdr_bytes/xdr_string need to free buffer on error [BZ #21461]
  - From: Florian Weimer
- Re: [PATCH] sunrpc: xdr_bytes/xdr_string need to free buffer on error [BZ #21461]
  - From: Andreas Schwab
- Re: [PATCH] sunrpc: xdr_bytes/xdr_string need to free buffer on error [BZ #21461]
  - From: Florian Weimer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]