This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 02/10] Suppress internal declarations for most of the testsuite.
On Fri, May 12, 2017 at 9:16 AM, Zack Weinberg <zackw@panix.com> wrote:
> On Fri, May 12, 2017 at 11:40 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>
>> This patch has
>>
>> /* The testsuite, and some other ancillary code, should be compiled against
>> as close an approximation to the installed headers as possible.
>> Defining this symbol disables most internal-use-only declarations
>> provided by this header, and all those provided by other internal
>> wrapper headers. */
>> #if IS_IN (testsuite) || defined IS_IN_build || defined __cplusplus
>> # define _ISOMAC 1
>> #endif
>>
>> However, benchtests don't define testsuite and _ISOMAC is undefined.
>> Programs in benchtests include sysdeps/generic/hp-timing-common.h
>> which includes sysdeps/generic/_itoa.h which uses attribute_hidden
>> attribute_hidden is defined only if _ISOMAC is undefined. That is
>> means C++ program in benchtests won't compile since
>> attribute_hidden is undefined.
>
> What is the current IS_IN value for benchtests? Is there any reason
-DMODULE_NAME=nonlib
> not to change it to 'testsuite'?
No, we can't since benchtests use glibc internal header files for hp-timing.
--
H.J.