This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/8] Consolidate Linux open implementation



On 11/05/2017 12:06, Andreas Schwab wrote:
> On Mai 08 2017, Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote:
> 
>> This patch consolidates the open Linux syscall implementation on
>> sysdeps/unix/sysv/linux/open{64}.c.  The changes are:
>>
>>   1. Remove open{64} from auto-generation syscalls.list.
>>   2. Add a new open{64}.c implementation.  For architectures that
>>      define __OFF_T_MATCHES_OFF64_T the default open64 will create
>>      alias to required open symbols.
>>   3. Use __NR_open where possible, otherwise use __NR_openat.
> 
> Perhaps we should use __NR_openat unconditionally?  (Even 2.6.32 already
> had it.)
> 
> Andreas.
> 

I would prefer also, although using __NR_open is a marginal optimization 
(which I do not think it would mater).  I will change it.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]