This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Add __BEGIN_DECLS and __END_DECLS for C++
On Thu, May 11, 2017 at 7:43 AM, Zack Weinberg <zackw@panix.com> wrote:
> On Thu, May 11, 2017 at 10:39 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Thu, May 11, 2017 at 7:29 AM, Zack Weinberg <zackw@panix.com> wrote:
>>> On Thu, May 11, 2017 at 10:18 AM, H.J. Lu <hongjiu.lu@intel.com> wrote:
>>>> Add __BEGIN_DECLS and __END_DECLS to support C++.
>>>>
>>>> Any comments?
>>>
>>> Could you please explain why you found this to be necessary?
>>> ifunc-impl-list.h is an internal header which should never be compiled
>>> as C++ in the first place.
>>
>> I am integrating memcpy_benchmark.cc:
>>
>> https://gist.github.com/ekelsen/b66cc085eb39f0495b57679cdb1874fa
>>
>> into glibc benchtests. It is a C++ program.
>
> This program does not appear to need ifunc-impl-list.h. Please elaborate.
>
Please see hjl/x86/optimize branch in glibc git repo.
--
H.J.