This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v4 2/4] Add C11 threads support
On 10/05/2017 17:22, Joseph Myers wrote:
> On Wed, 10 May 2017, Adhemerval Zanella wrote:
>
>> diff --git a/conform/Makefile b/conform/Makefile
>> index 63556b5..a79415f 100644
>> --- a/conform/Makefile
>> +++ b/conform/Makefile
>> @@ -34,9 +34,9 @@ conformtest-headers-ISO := assert.h ctype.h errno.h float.h limits.h locale.h \
>> conformtest-headers-ISO99 := $(conformtest-headers-ISO) complex.h fenv.h \
>> inttypes.h iso646.h stdbool.h stdint.h tgmath.h \
>> wchar.h wctype.h
>> -# Missing ISO11 expectations for: stdatomic.h threads.h.
>> +# Missing ISO11 expectations for: stdatomic.h
>> conformtest-headers-ISO11 := $(conformtest-headers-ISO99) stdalign.h \
>> - stdnoreturn.h uchar.h
>> + stdnoreturn.h uchar.h threads.h
>
> These header lists are meant to be alphabetical, so threads.h before
> uchar.h.
Ack.
>
>> +macro TSS_DTOR_ITERATIONS
>
> Use macro-int-constant, since C11 says this is an integer constant
> expression.
>
Ack, I will change them locally.