This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3 1/2] float128: Add _Float128 make bits to libm.

On Mon, 08 May 2017 16:05:15 -0300
"Tulio Magno Quites Machado Filho" <tuliom@linux.vnet.ibm.com> wrote:

> "Gabriel F. T. Gomes" <gftg@linux.vnet.ibm.com> writes:
> 
> > diff --git a/sysdeps/ieee754/float128/Versions
> > b/sysdeps/ieee754/float128/Versions new file mode 100644
> > [...]
> > +    __iscanonicalf128;  
> 
> Isn't it possible to reuse the implementation from bits/iscanonical.h and
> avoid exporting this symbol?
> I understand this would require to install iscanonicalf128.h with the new
> implementation.

You are right.  I can provide __iscanonicalf128 as a macro through
iscanonicalf128.h, then the line above (in the Versions file) is not
necessary.

Is this patch OK with this change?
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]