Re: [PATCH v3 1/2] float128: Add _Float128 make bits to libm.

["Tulio Magno Quites Machado Filho" <tuliom at linux dot vnet dot ibm dot com>]

"Gabriel F. T. Gomes" <gftg@linux.vnet.ibm.com> writes:

> diff --git a/sysdeps/ieee754/float128/Versions b/sysdeps/ieee754/float128/Versions
> new file mode 100644
> index 0000000..b6842c6
> --- /dev/null
> +++ b/sysdeps/ieee754/float128/Versions
> @@ -0,0 +1,146 @@
> +%include <float128-abi.h>
> +%ifndef FLOAT128_VERSION
> +% error "float128-abi.h must define FLOAT128_VERSION"
> +%endif
> +libm {
> +  FLOAT128_VERSION {
> +    __acosf128_finite;
> +    __acoshf128_finite;
> +    __asinf128_finite;
> +    __atan2f128_finite;
> +    __atanhf128_finite;
> +    __coshf128_finite;
> +    __exp10f128_finite;
> +    __exp2f128_finite;
> +    __expf128_finite;
> +    __finitef128;
> +    __fmodf128_finite;
> +    __fpclassifyf128;
> +    __gammaf128_r_finite;
> +    __hypotf128_finite;
> +    __iscanonicalf128;

Isn't it possible to reuse the implementation from bits/iscanonical.h and
avoid exporting this symbol?
I understand this would require to install iscanonicalf128.h with the new
implementation.

Otherwise, LGTM.

-- 
Tulio Magno