This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Fix wrong comments in struct ip_mreq_source
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Phil Blundell <pb at pbcl dot net>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Wed, 3 May 2017 15:53:19 -0400
- Subject: Re: Fix wrong comments in struct ip_mreq_source
- Authentication-results: sourceware.org; auth=none
- References: <1493840562.4543.47.camel@pbcl.net>
On 05/03/2017 03:42 PM, Phil Blundell wrote:
> The member names in this struct are fairly self-explanatory, but were
> contradicted by the comments. This patch swaps the comments around so
> that they match.
>
> I verified that the order of the elements does match the corresponding
> uapi header from the Linux kernel.
>
> OK to commit? (I wasn't quite sure whether this was obvious enough to
> count as a "trivial fix".)
>
> p.
>
> 2017-05-03 Phil Blundell <pb@pbcl.net>
>
> * inet/netinet/in.h (struct ip_mreq_source): Correct misplaced
> comments.
OK. This counts as a trivial fix. Even if you'd gotten it wrong the comment
change could just be another commit away from being right.
--
Cheers,
Carlos.