This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Create more sockets with SOCK_CLOEXEC [BZ #15722]
- From: Florian Weimer <fweimer at redhat dot com>
- To: GNU C Library <libc-alpha at sourceware dot org>
- Date: Wed, 19 Apr 2017 20:24:26 +0200
- Subject: Re: [PATCH] Create more sockets with SOCK_CLOEXEC [BZ #15722]
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=fweimer at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 3CC6C804EB
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 3CC6C804EB
- References: <20170418184058.04B574126BF74@oldenburg.str.redhat.com> <alpine.DEB.2.20.1704191518320.28423@digraph.polyomino.org.uk>
On 04/19/2017 05:19 PM, Joseph Myers wrote:
On Tue, 18 Apr 2017, Florian Weimer wrote:
diff --git a/inet/rcmd.c b/inet/rcmd.c
index b7cc7a8..e43d4af 100644
--- a/inet/rcmd.c
+++ b/inet/rcmd.c
@@ -383,6 +383,7 @@ rresvport_af (int *alport, sa_family_t family)
__set_errno (EAFNOSUPPORT);
return -1;
}
+ /* NB: No SOCK_CLOXEC for backwards compatibility. */
"CLOXEC" typo, repeated elsewhere in this patch.
Thanks, fixed with the attached patch.
Florian
rcmd/rexec: Fix typo in comment
2017-04-19 Florian Weimer <fweimer@redhat.com>
* inet/rcmd.c (rresvport_af): Fix typo in comment.
* inet/rexec.c (rexec_af): Likewise.
diff --git a/inet/rcmd.c b/inet/rcmd.c
index e43d4af..c285b9e 100644
--- a/inet/rcmd.c
+++ b/inet/rcmd.c
@@ -383,7 +383,7 @@ rresvport_af (int *alport, sa_family_t family)
__set_errno (EAFNOSUPPORT);
return -1;
}
- /* NB: No SOCK_CLOXEC for backwards compatibility. */
+ /* NB: No SOCK_CLOEXEC for backwards compatibility. */
s = __socket(family, SOCK_STREAM, 0);
if (s < 0)
return -1;
diff --git a/inet/rexec.c b/inet/rexec.c
index 82e15ae..bda5367 100644
--- a/inet/rexec.c
+++ b/inet/rexec.c
@@ -86,7 +86,7 @@ rexec_af (char **ahost, int rport, const char *name, const char *pass,
}
ruserpass(res0->ai_canonname, &name, &pass);
retry:
- /* NB: No SOCK_CLOXEC for backwards compatibility. */
+ /* NB: No SOCK_CLOEXEC for backwards compatibility. */
s = __socket(res0->ai_family, res0->ai_socktype, 0);
if (s < 0) {
perror("rexec: socket");