This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix missing timespec definition for sys/stat.h (BZ #21371)
- From: Wainer dos Santos Moschetta <wainersm at gmail dot com>
- To: libc-alpha at sourceware dot org
- Date: Wed, 19 Apr 2017 11:11:06 -0300
- Subject: Re: [PATCH] Fix missing timespec definition for sys/stat.h (BZ #21371)
- Authentication-results: sourceware.org; auth=none
- References: <1492548759-4319-1-git-send-email-adhemerval.zanella@linaro.org>
On 18-04-2017 17:52, Adhemerval Zanella wrote:
As indicated by the bug report, the 'struct timespec' definition
is not defined for '_XOPEN_SOURCE=700' and '_POSIX_C_SOURCE=200112L'.
It is because current code only includes its definition if __USE_ATFILE
is defined and the define is only set with:
1. _GNU_SOURCE and/or _ATFILE_SOURCE definition.
2. _POSIX_C_SOURCE >= 200809L
However, the 'st_*' fields in 'struct stat' are defined if __USE_XOPEN2K8.
This patch uses the same login for 'struct timespec' inclusion.
Perhaps s/login/logic. Other than that, LGTM.
Tested on x86_64-linux-gnu.
* io/sys/stat.h: Use __USE_XOPEN2K8 insteaf of __USE_ATFILE for
struct timespec definition.
---
io/sys/stat.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/io/sys/stat.h b/io/sys/stat.h
index 2ada4a5..ac7ef1f 100644
--- a/io/sys/stat.h
+++ b/io/sys/stat.h
@@ -26,7 +26,7 @@
#include <bits/types.h> /* For __mode_t and __dev_t. */
-#ifdef __USE_ATFILE
+#ifdef __USE_XOPEN2K8
# include <bits/types/struct_timespec.h>
#endif