This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] SYSCALL_CANCEL: reduce the size of generated code
- From: Florian Weimer <fweimer at redhat dot com>
- To: Yury Norov <ynorov at caviumnetworks dot com>, libc-alpha at sourceware dot org
- Cc: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- Date: Sat, 15 Apr 2017 09:37:58 +0200
- Subject: Re: [PATCH] SYSCALL_CANCEL: reduce the size of generated code
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=fweimer at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com B7B49C05678D
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B7B49C05678D
- References: <1492200452-4653-1-git-send-email-ynorov@caviumnetworks.com>
On 04/14/2017 10:07 PM, Yury Norov wrote:
SYSCALL_CANCEL() currently calls INLINE_SYSCALL_CALL() both in true and
false branches of the "if (SINGLE_THREAD_P)" condition. If arguments that
passed in INLINE_SYSCALL_CALL() are wrapped with tricky macros or require
other additional handling, the code that does it becomes duplicated, and
it may increase the size of function that use it significantly.
It also widens the window for the race, so I'm not sure if this is a
good idea.
I think this code will change with the cancellation fixes anyway.
Thanks,
Florian