This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] posix: Add SIGSEGV on the trap list for globtest.sh
On 12/04/2017 10:19, Florian Weimer wrote:
> On 04/12/2017 02:35 PM, Adhemerval Zanella wrote:
>> Ok, here is a version 2.
>>
>> --
>>
>> This patch prevents lingering files for SIGSEGV failures by adding
>> a cleanup handler on trap handler. Checked on x86_64-linux-gnu.
>>
>> * posix/globtest.sh: Add cleanup for the signal to act on a trap.
>
> Looks reasonable.
>
>> +cleanup()
>
> Not sure what the preferred style is here, “cleanup () {” or yours.
>
> GNU style for shell scripts seems to be 4 space indentation.
>
> Thanks,
> Florian
GLIBC usage seems to tend for 'function () {', although there both usage
across the scripts. I will change it and use 4 space indentation.