This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Consolidate Linux mmap implementation
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: libc-alpha at sourceware dot org
- Date: Thu, 6 Apr 2017 17:00:48 -0300
- Subject: Re: [PATCH] Consolidate Linux mmap implementation
- Authentication-results: sourceware.org; auth=none
- References: <1490369962-29989-1-git-send-email-adhemerval.zanella@linaro.org> <87vaqy372c.fsf@linux-m68k.org> <ff1efa57-30ee-4c0f-76c3-784013f2d78c@linaro.org>
On 24/03/2017 14:57, Adhemerval Zanella wrote:
>
>
> On 24/03/2017 14:42, Andreas Schwab wrote:
>> On Mär 24 2017, Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote:
>>
>>> +void *
>>> +__mmap (void *addr, size_t len, int prot, int flags, int fd, off_t offset)
>>> +{
>>> + MMAP_CHECK_PAGE_UNIT
>>
>> I think it would be better to define this as a function style macro.
>>
>> Andreas.
>>
>
> I do not have preference here, I changed to:
>
> # define MMAP_CHECK_PAGE_UNIT() ...
>
Ping.