This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3] Add page tests to string/test-strnlen.
- From: "Tulio Magno Quites Machado Filho" <tuliom at linux dot vnet dot ibm dot com>
- To: Wainer dos Santos Moschetta <wainersm at linux dot vnet dot ibm dot com>, libc-alpha at sourceware dot org
- Cc:
- Date: Wed, 05 Apr 2017 11:51:40 -0300
- Subject: Re: [PATCH v3] Add page tests to string/test-strnlen.
- Authentication-results: sourceware.org; auth=none
- References: <20170331203729.23812-1-wainersm@linux.vnet.ibm.com>
Wainer dos Santos Moschetta <wainersm@linux.vnet.ibm.com> writes:
> May be tricky for otimized implementations to handle strings around
> page boundary once, for instance, it is performed unaligned loads or
> when maxlen is used as a hint for vectorized loops. The test cases
> should unveil regression bugs on these cases.
>
> To some extend do_random_tests in string/test-strnlen tests strings
> placed at page end but it does not cover all cases. So this change
> adds tests which consists of placing strings of varying sizes ending
> at the page boundary. It also combines with different values of maxlen.
>
> Tested on ppc64le and x86_64.
>
> 2017-03-31 Wainer dos Santos Moschetta <wainersm@linux.vnet.ibm.com>
>
> * string/test-strnlen.c (do_page_tests): New function
> to check length of strings ending at the page boundary.
> (test_main): Added call to the do_page_tests function.
LGTM too.
Pushed as ff65c87.
--
Tulio Magno