This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Update elf tests to use the support test driver.
- From: Zack Weinberg <zackw at panix dot com>
- To: Wainer dos Santos Moschetta <wainersm at linux dot vnet dot ibm dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Sat, 1 Apr 2017 09:58:04 -0400
- Subject: Re: [PATCH] Update elf tests to use the support test driver.
- Authentication-results: sourceware.org; auth=none
- References: <20170329151407.6476-1-wainersm@linux.vnet.ibm.com> <32f6acde-964a-172d-43d7-69514932aaba@linaro.org> <87mvc2scv8.fsf@mid.deneb.enyo.de> <a51ff7cf-7103-15aa-48ab-eacb1fcd6ccf@linux.vnet.ibm.com>
On Fri, Mar 31, 2017 at 4:52 PM, Wainer dos Santos Moschetta
<wainersm@linux.vnet.ibm.com> wrote:
>
> Side note: the original tst-tls-manydynamic.c code uses xpthread_* functions.
> So I had to include support/xthread.h to avoid its breakage.
This is part of the cost of the change, yes.
> In test-skeleton.c you can see the following:
>
> #ifdef _PTHREAD_H
> # include <support/xthread.h>
> #endif /* _PTHREAD_H */
This is an example of the implicit magic behavior that we are trying
to get away from with this change. Please don't add it to the new
test driver.
zw