This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[PATCH 2/2] fs: reject unknown open flags
- From: Christoph Hellwig <hch at lst dot de>
- To: Linus Torvalds <torvalds at linux-foundation dot org>, Alexander Viro <viro at zeniv dot linux dot org dot uk>
- Cc: linux-api at vger dot kernel dot org, linux-fsdevel at vger dot kernel dot org, linux-kernel at vger dot kernel dot org, libc-alpha at sourceware dot org
- Date: Thu, 30 Mar 2017 18:33:27 +0200
- Subject: [PATCH 2/2] fs: reject unknown open flags
- Authentication-results: sourceware.org; auth=none
- References: <20170330163327.23920-1-hch@lst.de>
This way userspace can probe for actually supported flags.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
fs/open.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fs/open.c b/fs/open.c
index 949cef29c3bb..9106ed7310f0 100644
--- a/fs/open.c
+++ b/fs/open.c
@@ -900,6 +900,9 @@ static inline int build_open_flags(int flags, umode_t mode, struct open_flags *o
int lookup_flags = 0;
int acc_mode = ACC_MODE(flags);
+ if (flags & ~VALID_OPEN_FLAGS)
+ return -EINVAL;
+
if (flags & (O_CREAT | __O_TMPFILE))
op->mode = (mode & S_IALLUGO) | S_IFREG;
else
--
2.11.0