This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3] Add random memcpy test


On Tuesday 28 March 2017 02:23 AM, Steve Ellcey wrote:
> Here is a patch so that bench-memcpy-random.c prints out timings for
> all the IFUNC versions of memcpy.  The TEST_NAME change is clear,
> TEST_NAME isn't really the name of the test but the name of the routine
> being tested.  If you call it memcpy-random it looks for IFUNC versions
> of the memcpy-random function instead of the memcpy function.  I also
> changed the IMPL call to have 1 instead of 0 as the second argument.  I
> don't really understand this change, but it is what the other two
> memcpy tests do so I copied them and it seems to work.  Tested on x86
> and aarch64.
> 
> Steve Ellcey
> sellcey@cavium.com
> 
> 
> 2017-03-27  Steve Ellcey  <sellcey@caviumnetworks.com>
> 
> 	* benchtests/bench-memcpy-random.c (TEST_NAME): Change to memcpy.
> 	(IMPL) Call with 1 instead of 0 as argument.

The flag is to enable testing it.  This patch is OK.

Thanks,
Siddhesh


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]