This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/6] Move mutex and condition variable definition to common header


Thank you for the patches.
See my comment below.
I.

On 21.3.2017 14:40, Adhemerval Zanella wrote:
This patch sorts out pthread_mutex_t and pthread_cond_t in new files,
so new C11 types could be based on pthread types without corrupting
namespaces and exposing pthread symbols.
...

diff --git a/bits/thread-shared-types.h b/bits/thread-shared-types.h
new file mode 100644
index 0000000..98f2084
--- /dev/null
+++ b/bits/thread-shared-types.h
+/* This file is required to have a shared types definition
+   between POSIX threads and C11 threads. It allows to
+   header files like pthread.h and thread.h to define their types
+   with the same size and fields without corrupting namespaces.

Typo here. I'd suggest:
-   between POSIX threads and C11 threads. It allows to
+   between POSIX threads and C11 threads. It allows


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]