This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Update string tests to use the support test driver.


On 03/20/2017 01:27 PM, Carlos O'Donell wrote:
> On 03/20/2017 11:29 AM, Wainer dos Santos Moschetta wrote:
>> This patch is much like b598e134773f, instead applied to string tests.
>>
>> -- >8 --
>> Replaced all imports of test-skeleton.c with support/test-driver.c.
>>
>> In some cases it was needed to adjust do_test to return int
>> instead of static int since that is the method's signature expected by
>> test-driver.c.
>>
>> Checked on x86_64.
> This looks good to me.

Thanks. Do you mind to merge it?
 
>
> I would be happy to see us fully migrated to support/ code so we can
> delete some of the old compat code and just have one way of doing
> the testing.
>
I see around 800 .c files including the legacy test skeleton. I could call for volunteers so that we could split the task and make the migration.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]