This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Use append attribution to CFLAGS in wcsmbs
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: "Gabriel F. T. Gomes" <gftg at linux dot vnet dot ibm dot com>, <libc-alpha at sourceware dot org>
- Date: Mon, 13 Mar 2017 16:37:43 +0000
- Subject: Re: [PATCH] Use append attribution to CFLAGS in wcsmbs
- Authentication-results: sourceware.org; auth=none
- References: <1488991673-21932-1-git-send-email-gftg@linux.vnet.ibm.com> <20170312020417.GK31094@vapier>
On Sat, 11 Mar 2017, Mike Frysinger wrote:
> On 08 Mar 2017 13:47, Gabriel F. T. Gomes wrote:
> > CFLAGS for several files in wcsmbs/Makefile are set without the append
> > operator ("+="), thus ignoring other attributions. This patch changes
> > that so Makefiles in sysdeps can set extra compilation flags. This is
> > being done in preparation for future float128 patches.
>
> i'm not against this, but it seems like we should be doing this
> everywhere ? when i grep for CFLAGS-xxx.c, there's about 650
> using = and 250 using +=.
See the discussion starting at
<https://sourceware.org/ml/libc-alpha/2012-11/msg00798.html> (and
<https://sourceware.org/ml/libc-alpha/2013-01/msg00247.html>). Given that
CFLAGS are the right way of handling a particular file (rather than
diagnostic pragmas, #define, etc., directly in the source code), I think
appending makes sense unless there is a specific reason for not doing so
in a particular case (and working out if any existing cases are
deliberately not appending may be tricky).
--
Joseph S. Myers
joseph@codesourcery.com