This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/3] Miscellaneous low-risk changes preparing for _ISOMAC testsuite.
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Zack Weinberg <zackw at panix dot com>, libc-alpha at sourceware dot org
- Cc: joseph at codesourcery dot com, adhemerval dot zanella at linaro dot org, fweimer at redhat dot com
- Date: Wed, 1 Mar 2017 15:19:11 -0500
- Subject: Re: [PATCH 1/3] Miscellaneous low-risk changes preparing for _ISOMAC testsuite.
- Authentication-results: sourceware.org; auth=none
- References: <20170301140212.14354-1-zackw@panix.com> <20170301140212.14354-2-zackw@panix.com>
On 03/01/2017 09:02 AM, Zack Weinberg wrote:
> These are a grab bag of changes where the testsuite was using internal
> symbols of some variety, but this was straightforward to fix, and the
> fixed code should work with or without the change to compile the
> testsuite under _ISOMAC.
> * nss/tst-cancel-getpwuid_r.c: Include nss.h.
> * string/strcasestr.c: No need to include config.h.
> * sysdeps/powerpc/fpu/tst-setcontext-fpscr.c: Include
> sys/auxv.h. Don't include sysdep.h.
> * sysdeps/powerpc/tst-set_ppr.c: Don't include dl-procinfo.h.
>
> * dlfcn/tst-dladdr.c: Don't include ldsodefs.h. Don't use
> DL_LOOKUP_ADDRESS.
> * math/test-misc.c: Instead of testing NO_LONG_DOUBLE, test whether
> LDBL_MANT_DIG is greater than DBL_MANT_DIG.
> * sysdeps/unix/sysv/linux/Makefile (CFLAGS-tst-writev.c): Use
> sysconf (_SC_PAGESIZE) instead of __getpagesize in definition
> of ARTIFICIAL_LIMIT.
> * sysdeps/unix/sysv/linux/tst-clone.c [__ia64__]: Add extern
> declaration of __clone2.
Looks good to me.
--
Cheers,
Carlos.