This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 3/4] Miscellaneous 'safe' testsuite changes.
On 02/20/2017 09:52 AM, Joseph Myers wrote:
> On Mon, 20 Feb 2017, Zack Weinberg wrote:
>
>> atomic.h cannot be used by code compiled under _ISOMAC, but
>> stdatomic.h can. There are quite a few tests that use atomic.h;
>> most of them were not straightforward to change to stdatomic.h,
>> but nptl/tst-join7.c was, so I did that.
>
> stdatomic.h is not available before GCC 4.9, and our minimum version
> for building glibc is 4.7 (although you can't use
> build-many-glibcs.py with versions before 4.9 because of missing
> features for bootstrapping cross compilers with glibc, in particular
> --with-glibc-version).
...
>> Finally, tst-setgetname.c was using kernel-features.h (also a no-go
>> in _ISOMAC mode) just for one __ASSUME macro which it doesn't
>> really need.
>
> That macros is only used there. Effectively, its function is to say
> "when we remove support for 2.6.32 kernels this code can be
> removed".
Rather than hold up this patch on questions of whether we can bump the
minimum compiler or kernel requirement, I am going to drop these changes
and move the affected tests to tests-internal.
zw