This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] build-many-glibcs: don't crash if email is not configured
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Zack Weinberg <zackw at panix dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Thu, 16 Feb 2017 23:08:55 +0000
- Subject: Re: [PATCH] build-many-glibcs: don't crash if email is not configured
- Authentication-results: sourceware.org; auth=none
- References: <20170216220747.16020-1-zackw@panix.com> <alpine.DEB.2.20.1702162217080.14439@digraph.polyomino.org.uk> <CAKCAbMjw-cm0_2g=L2JH3VsWqz0qpKVv4qkdw=KHoFVgB43Aew@mail.gmail.com>
On Thu, 16 Feb 2017, Zack Weinberg wrote:
> Not so; bot_build_mail is called at the end of each "action" in a cycle:
>
> for a in actions:
> if must_build[a]:
> build_time = datetime.datetime.utcnow()
> print('Rebuilding %s at %s.' % (a, str(build_time)))
> self.bot_run_self([], a)
> self.load_build_state_json()
> self.bot_build_mail(a, build_time)
> print('Bot cycle done at %s.' % str(datetime.datetime.utcnow()))
>
> And it takes the "action" as an argument, so making it send mail only
> once for the entire process would be a fair bit of surgery. Given
> that, do you still want self.email_warning removed? It seems to me it
> would be annoying to get the warning more than once per invocation.
Thanks for the correction. The patch is OK as-is.
--
Joseph S. Myers
joseph@codesourcery.com