This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Pre-approval for #include adjustments to the testsuite


I'm working on a patch to compile as much of the testsuite as possible
in _ISOMAC mode, as a step toward compiling the testsuite against
installed headers.  This has a lot of tentacles and isn't even close to
ready for review yet, but the bulk of the changes required turn out to
be boring and repetitive: the wrapper headers include each other
casually, so lots of test programs are missing #includes that they
really should have.  For instance, many of the io/tst-*at.c programs are
getting away with not including sys/stat.h because include/stdlib.h does
it for them.  Here's an excerpt from the changelog for the current
iteration of the patch:

    	* dirent/opendir-tst1.c: Include sys/stat.h.
    	* dirent/tst-fdopendir.c: Include sys/stat.h.
    	* dirent/tst-fdopendir2.c: Include stdlib.h.
    	* dirent/tst-scandir.c: Include stdbool.h.
    	* elf/tst-auditmod1.c: Include link.h and stddef.h.
    	* elf/tst-tls15.c: Include stdlib.h.
    	* elf/tst-tls16.c: Include stdlib.h.
    	* elf/tst-tls17.c: Include stdlib.h.
    	* elf/tst-tls18.c: Include stdlib.h.
    	* iconv/tst-iconv6.c: Include endian.h.
    	* iconvdata/bug-iconv11.c: Include limits.h.
    	* io/test-utime.c: Include stdint.h.
	...

You get the idea.  To reduce churn and make the core patch easier to
review, I would like to commit changes like these piecemeal, ahead of
the main patch.  So I'm asking for blanket pre-approval to commit
additions and/or removals of #include lines to files that are part of
the testsuite, making no other changes.  Is that OK?

zw


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]