This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] tst-setcontext2: avoid bug from compiler optimization


On 01/27/2017 09:34 PM, Chris Metcalf wrote:
I'd like to commit the one-line patch below that just declares the context
variables for test-setcontext2 as static.  I think the consensus is that
this is necessary,

No, I think the test is supposed to work as-is; it is valid.

So if this test is broken, it is a bug in the implementation of the context switching functions (as they are visible to applications, i.e. the fix might not be in the functions themselves, but adjusting their calling conventions, inhibiting GCC optimizations which make incorrect assumptions, etc.).

If we do not have a fix right now, it is better to let the test keep failing (perhaps XFAIL it), rather than tweaking it so that it tests something else.

Thanks,
Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]