This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Remove i686, x86_64, and powerpc strtok implementations
- From: Siddhesh Poyarekar <siddhesh at gotplt dot org>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, libc-alpha at sourceware dot org
- Date: Wed, 25 Jan 2017 11:09:16 +0530
- Subject: Re: [PATCH] Remove i686, x86_64, and powerpc strtok implementations
- Authentication-results: sourceware.org; auth=none
- References: <1483712763-27890-1-git-send-email-adhemerval.zanella@linaro.org>
On Friday 06 January 2017 07:56 PM, Adhemerval Zanella wrote:
> The idea of this patch is to fix BZ#16640 to align all the
> implementations to a same contract. However, with newer strtok
> code it is better to get remove the old assembly ones instead of
> fix them.
Looks good to me, but for 2.26. I understand that this is a bug fix but
switching routines does not seem right for this stage of development.
These assembly routines have not been tuned for years and it is evident
that gcc does a better job of tuning the routine.
Siddhesh